Comments on: Implementing HAT-Tries in Java

By: Mark Dennehy

Mark Dennehy — Mon, 21 Apr 2014 16:47:56 +0000

In reply to Sri C. Afraid not Sri, any more than I've put up and I'd be worried about breaching NDA T&Cs.

By: Sri C

Sri C — Tue, 15 Apr 2014 20:29:57 +0000

Can you share the entire class code? Would like to explore usage for one scenario.

By: Florian Westreicher

Florian Westreicher — Fri, 19 Feb 2010 01:38:41 +0000

Just a suggestion:
replace your
if (child.getClass().getName() == “HATTrieNode”) { … }
switches with if(child instanceof HATTrieNode){ … }
your code is not type or packet safe.
also using ‘ == ‘ on Strings is a bad idea (and should not work actually), rather use .equals()

By: Patrick van Logchem

Patrick van Logchem — Mon, 23 Feb 2009 22:13:24 +0000

I’m aware this was written quite a while ago, but I’m still curious for the rest of the code; HATTrieNode.append() is missing for example. Code on HATTrie’s is hard to find, so would you please publish all of it (or possibly mail it to me?) Thanks in advance!

One little thing about HATTrieNode.addString() : If you place the check on (inputString.length > 1) one line lower (making only the call to System.arraycopy conditional), this would render the second statement-block (handling the terminal nodes) obsolete. Just a thought.